Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shock burning docs #2817

Merged
merged 4 commits into from
May 1, 2024
Merged

Update shock burning docs #2817

merged 4 commits into from
May 1, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 8, 2024 •
edited
Loading

PR summary

this describes the new shock burning algorithm.

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
update the reaction docs
7529cdc 
this describes the new shock burning algorithm
@zingale zingale changed the base branch from main to development April 8, 2024 12:39
@zingale
Copy link
Member Author

zingale commented Apr 8, 2024

blocked by #2728

@zingale zingale merged commit 1caf5d3 into AMReX-Astro:development May 1, 2024
25 checks passed
@zingale zingale deleted the update_shock_burning_docs branch May 1, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yut23 yut23 yut23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @yut23